fix: hot reload was too aggresive #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
changed the title
3 tasks
Lundez
reviewed
Jun 28, 2023
|
Thank you @Lundez for opening the issue and thinking along! |
maartenbreddels
added a commit
that referenced
this pull request
Jun 29, 2023
maartenbreddels
added a commit
that referenced
this pull request
Jul 20, 2023
* fix: autorouting should pick up modules that only define routes Instead of having a Page component, we should also just allow a user to define a set of routes. This is what we need for the /apps/scrolling example. * fix: hot reload was too aggresive (#179) * test: enable reload tests * fix: do not reload modules that are not under the app directory Fixes #177 Fixes #148 * clean up code * __file__ can be None * call clear from the test code * move to subdir so we do not reload the test modules * also catch AttributeError when app is None during unitesting * fix: solara patches should have no effect outside a solara context * pass cls * fix: ignore typing * pass cls * fix: ignore typing --------- Co-authored-by: Maarten A. Breddels <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix
First step is to enable some tests that were flakey before.