From f3297f80453835180a2c0ca79a26ca5e33bf42c7 Mon Sep 17 00:00:00 2001
From: Iisakki Rotko <iisakki.rotko@gmail.com>
Date: Mon, 18 Mar 2024 11:31:11 +0100
Subject: [PATCH] chore, ci: Bump upload/download-artifacts to v4

---
 .github/workflows/test.yaml | 39 +++++++++++++++++--------------------
 1 file changed, 18 insertions(+), 21 deletions(-)

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
index 8f3a855ed..ffa3d007e 100644
--- a/.github/workflows/test.yaml
+++ b/.github/workflows/test.yaml
@@ -82,7 +82,7 @@ jobs:
 
       - name: Upload Test artifacts
         if: always()
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: solara-builds-${{ github.run_number }}
           path: |
@@ -145,7 +145,7 @@ jobs:
 
       - uses: actions/checkout@v4
 
-      - uses: actions/download-artifact@v2
+      - uses: actions/download-artifact@v4
         with:
           name: solara-builds-${{ github.run_number }}
 
@@ -204,8 +204,7 @@ jobs:
         uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
-
-      - uses: actions/download-artifact@v2
+      - uses: actions/download-artifact@v4
         with:
           name: solara-builds-${{ github.run_number }}
 
@@ -256,16 +255,16 @@ jobs:
 
       - name: Upload Test artifacts
         if: steps.install_no_lock.outputs.exit_code != 'NO_DIFF'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: test-results
+          name: test-results-integration-os${{ matrix.os }}-python${{ matrix.python-version }}-voila${{ matrix.voila }}-ipywidgets${{ matrix.ipywidgets }}
           path: test-results
 
       - name: Upload CI package locks
         if: steps.install_no_lock.outputs.exit_code != 'NO_DIFF' && github.event_name == 'schedule' || steps.prepare.outputs.locks_exist == 'false'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: ci-package-locks
+          name: ci-package-locks-integration-os${{ matrix.os }}-python${{ matrix.python-version }}-voila${{ matrix.voila }}-ipywidgets${{ matrix.ipywidgets }}
           path: ${{ env.LOCK_FILE_LOCATION }}
 
   integration-test-vue3:
@@ -294,8 +293,7 @@ jobs:
         uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
-
-      - uses: actions/download-artifact@v2
+      - uses: actions/download-artifact@v4
         with:
           name: solara-builds-${{ github.run_number }}
 
@@ -348,17 +346,16 @@ jobs:
 
       - name: Upload Test artifacts
         if: steps.install_no_lock.outputs.exit_code != 'NO_DIFF'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: test-results
-          path: |
-            test-results
+          name: test-results-integration-vue3-os${{ matrix.os }}-voila${{ matrix.voila }}-ipywidgets${{ matrix.ipywidgets }}
+          path: test-results
 
       - name: Upload CI package locks
         if: steps.install_no_lock.outputs.exit_code != 'NO_DIFF' && github.event_name == 'schedule' || steps.prepare.outputs.locks_exist == 'false'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: ci-package-locks
+          name: ci-package-locks-integration-vue3-os${{ matrix.os }}-voila${{ matrix.voila }}-ipywidgets${{ matrix.ipywidgets }}
           path: ${{ env.LOCK_FILE_LOCATION }}
 
   unit-test:
@@ -421,9 +418,9 @@ jobs:
 
       - name: Upload CI package locks
         if: github.event_name == 'schedule' || steps.prepare.outputs.locks_exist == 'false'
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: ci-package-locks
+          name: ci-package-locks-unit-os${{ matrix.os }}-python${{ matrix.python }}-ipywidgets${{ matrix.ipywidgets }}
           path: ${{ env.LOCK_FILE_LOCATION }}
 
   update-ci-package-locks:
@@ -442,9 +439,9 @@ jobs:
             echo "::set-output name=locks_exist::false"
           fi
 
-      - uses: actions/download-artifact@v2
+      - uses: actions/download-artifact@v4
         with:
-          name: ci-package-locks
+          pattern: ci-package-locks-*
 
       - name: Update CI package locks
         if: (github.event_name == 'schedule' && success()) || steps.prepare.outputs.locks_exist == 'false'
@@ -469,7 +466,7 @@ jobs:
         with:
           python-version: 3.7
 
-      - uses: actions/download-artifact@v2
+      - uses: actions/download-artifact@v4
         with:
           name: solara-builds-${{ github.run_number }}