From eb530a48312cab0f13c982a10c6b641fbfc6af5c Mon Sep 17 00:00:00 2001 From: "Maarten A. Breddels" Date: Wed, 13 Sep 2023 21:21:37 +0200 Subject: [PATCH] fix: make vega and altair work in the jupyter notebook Because the vega url does not end with .js the CdnHandler does not serve the file with the correct mimetype. We do not store the mime type on disk, so we do not know the mimetype of the file. Currently, the mimetype is guessed based on the file extension. By giving a more explicit path that ends in .js, we can make sure the mimetype is set correctly. In the end this caused the Altair component not to work. --- solara/widgets/vue/vegalite.vue | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/solara/widgets/vue/vegalite.vue b/solara/widgets/vue/vegalite.vue index 846474b76..81d78846d 100644 --- a/solara/widgets/vue/vegalite.vue +++ b/solara/widgets/vue/vegalite.vue @@ -12,9 +12,9 @@ module.exports = { require.config({ map: { '*': { - 'vega': `${this.getCdn()}/vega@5`, - 'vega-lite': `${this.getCdn()}/vega-lite@5.8.0`, - 'vega-embed': `${this.getCdn()}/vega-embed@6`, + 'vega': `${this.getCdn()}/vega@5/build/vega.min.js`, + 'vega-lite': `${this.getCdn()}/vega-lite@5.8.0/build/vega-lite.min.js`, + 'vega-embed': `${this.getCdn()}/vega-embed@6/build/vega-embed.min.js`, } } })