From 8014ec50a227916683574113b4d01a3e8dad3e84 Mon Sep 17 00:00:00 2001 From: "Maarten A. Breddels" Date: Wed, 8 Nov 2023 19:23:30 +0100 Subject: [PATCH] fix: meta tags didn't overwrite correctly --- solara/components/head_tag.vue | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/solara/components/head_tag.vue b/solara/components/head_tag.vue index bbf6c7ee6..4dc6892a0 100644 --- a/solara/components/head_tag.vue +++ b/solara/components/head_tag.vue @@ -36,7 +36,7 @@ module.exports = { const tags = window._solaraHeadTags[this.key]; let deepestTag = tags[0]; for (let i = 1; i < tags.length; i++) { - if (tags[i].level > deepestTitle.level) { + if (tags[i].level > deepestTag.level) { deepestTag = tags[i]; } } @@ -46,8 +46,8 @@ module.exports = { document.head.appendChild(el); } else { el.innerHTML = ''; - for (let i = 0; i < el.attributes.length; i++) { - el.removeAttribute(el.attributes[i].name); + while (el.attributes.length > 0) { + el.removeAttribute(el.attributes[0].name); } } Object.keys(deepestTag.attributes).forEach((key) => {