-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support lighting and shadows for scatter and mesh #342
Merged
Commits on May 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 942de8f - Browse repository at this point
Copy the full SHA 942de8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8159547 - Browse repository at this point
Copy the full SHA 8159547View commit details
Commits on Aug 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a0cb996 - Browse repository at this point
Copy the full SHA a0cb996View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1cb0f6e - Browse repository at this point
Copy the full SHA 1cb0f6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5006fb6 - Browse repository at this point
Copy the full SHA 5006fb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fc186e - Browse repository at this point
Copy the full SHA 1fc186eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6fe9d7 - Browse repository at this point
Copy the full SHA a6fe9d7View commit details -
🐛 a mesh would not always cast shadows, since its depth material was …
…cached Example program: import ipyvolume as ipv import numpy as np def scene(): f = ipv.figure(debug=True) ipv.xyzlim(-1, 1) x = np.array([0.1, 0.5], dtype=np.float32) ipv.material_lambert() s = ipv.scatter(x, x, x, marker="sphere", size=10); ipv.material_clear() k = ipv.examples.klein_bottle(show=False) ipv.xyzlim(2) ipv.material_phong() ipv.material_clear() m = ipv.plot_plane('bottom') ipv.show() return f f = scene() ipv.light_ambient(intensity=0.4) ipv.light_directional(position=[-3, 10, 3]); The klein_bottle would not cast a shadown, unless we modify alphaTest
Configuration menu - View commit details
-
Copy full SHA for 5585b8c - Browse repository at this point
Copy the full SHA 5585b8cView commit details -
✨ debug mode can render shadow map
This appears black if alphaTest for mesh is changed to != 0.5
Configuration menu - View commit details
-
Copy full SHA for 2e8e83f - Browse repository at this point
Copy the full SHA 2e8e83fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a772968 - Browse repository at this point
Copy the full SHA a772968View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd087b6 - Browse repository at this point
Copy the full SHA dd087b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc065f0 - Browse repository at this point
Copy the full SHA fc065f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f790245 - Browse repository at this point
Copy the full SHA f790245View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7550194 - Browse repository at this point
Copy the full SHA 7550194View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a09767 - Browse repository at this point
Copy the full SHA 7a09767View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.