Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Lights and Shadows #308

Open
wants to merge 132 commits into
base: master
Choose a base branch
from
Open

Conversation

TimoFriedri
Copy link
Contributor

Hi,

we have added light and shadow support to ipyvolume.
We tried to not interfere with the existing functionality of ipyvolume,
As long as no lights are added, nothing changes for the user.
As soon as a light is added to the Figure (Scene), we change to our custom shaders. But this can also be reversed on the fly by just setting the lighting_mode.

The status is as follows:
plot_mesh, plot_trisurf, plot_surface
These 3 fully support light and shadows for:
spot_light, point_light, directional_light, hemisphere_light and ambient_light

scatter
We only have a working implementation for hemisphere and ambient_light.
Due to a bug in the old threejs version, this does not work correctly.
Please have a look at the issue for more information.
#276

We have added a Notebook with examples for the usage of the new functionality.
Unittests are added.
Inline doc should be present.

rinftech-github and others added 30 commits March 17, 2020 22:16
Sliders and color picker widgets added
- Range Widget, Dropdown  Widgets added
- opacity and brightness granularity and range was changed; 
- update_axes_range() function updated  in order to fix the error caused by y_size changes;
- color picker was fixed;
…hadowmap issue. Work in progress lighting demo notebook
…r has DEFAULT and PHYSICAL lighting models
@rinftech-github
Copy link

#341
Integrated changes into branch feat_lighting_merge.
Removed light widget.
Encountered scaling issues not introduced by my code.
This PR can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants