Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: jupyter lite deploy should use repo build, not from pypi #29

Open
maartenbreddels opened this issue May 7, 2023 · 4 comments
Open

Comments

@maartenbreddels
Copy link
Contributor

If we do a release, the CI script installs from pypi the old version, we want it to be always up to date (I think)

@kolibril13
Copy link
Collaborator

we want it to be always up to date

do you mean the latest release version, or the latest version from the master branch?
I think we should always use the latest release version.

I just opened the latest JupyterLite, which is now running in 0.3.0 as expected.
But I guess that only happened because you trigger redeploy?
image

@maartenbreddels
Copy link
Contributor Author

indeed, i re-triggered it. But if we re-deploy jupyter lite on every commit, then it's not in sync with the released version.

@kolibril13
Copy link
Collaborator

One quick and dirty solution: We could delay the pages build for 15 minutes after the commit, that should be enough time to have the latest pypi version, here is an action for that https://github.com/jakejarvis/wait-action

I can also investigate how other projects solve this problem and find a better solution in a few weeks.

@maartenbreddels
Copy link
Contributor Author

Yeah, it's not urgent, but we'll forget it for the next release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants