From b99fb638e1e0cb8f4c011a75015498ada958ef02 Mon Sep 17 00:00:00 2001 From: changzhen Date: Fri, 16 Aug 2024 11:01:36 +0800 Subject: [PATCH] add corner case for dispath suspension proposal Signed-off-by: changzhen --- docs/proposals/dispatch-suspension/README.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/docs/proposals/dispatch-suspension/README.md b/docs/proposals/dispatch-suspension/README.md index 4664ee170247..2a984c181e73 100644 --- a/docs/proposals/dispatch-suspension/README.md +++ b/docs/proposals/dispatch-suspension/README.md @@ -153,7 +153,7 @@ type WorkSpec struct { } ``` -A new ConditionType called `SuspendDispatching` is introduced to describe the distribution suspension status of the Work resource. Meanwhile, the system will also report events to record the suspension of resource distribution. +A new ConditionType called `Dispatching` is introduced to describe the distribution suspension status of the Work resource. Meanwhile, the system will also report events to record the suspension of resource distribution. ### User usage example @@ -195,7 +195,7 @@ spec: status: conditions: - lastTransitionTime: "2024-07-01T08:33:28Z" - message: resource distribution is in a pause state. + message: Work dispatching is in a suspended state. reason: SuspendDispatching status: "True" type: Dispatching @@ -256,6 +256,12 @@ If, after synchronizing the new version of the resource to the member1 cluster, Q&A: How to remove the annotation `propagation.karmada.io/instruction` from Work? It can be carried by the `Dispatching` field in the Work. +### Corner Case Consideration + +1. Resource dispatching suspension does not block resource deletion. + +When a user specifies through PropagationPolicy that a resource is in a dispatching suspension, and then performs a deletion operation with the intention of removing the resource, the resource will be deleted normally without blocking the deletion, thus preventing leftover resources in the member clusters. + ### Test Plan #### UT