Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate QueueEmpty signal #231

Open
Schmiddiii opened this issue Jan 21, 2024 · 3 comments · May be fixed by #293
Open

Propagate QueueEmpty signal #231

Schmiddiii opened this issue Jan 21, 2024 · 3 comments · May be fixed by #293
Assignees
Milestone

Comments

@Schmiddiii
Copy link
Contributor

Schmiddiii commented Jan 21, 2024

This prevents a few nice-to-have features of clients, e.g. notifying only messages which have not yet read or needlessly reordering the channels a lot when there are many messages to receive.

Note that the InitialSync is not really a perfect solution for that, e.g. if the device has been running for a while but was disconnected from the internet, InitialSync probably will not really help.

@gferon
Copy link
Collaborator

gferon commented Mar 1, 2024

That sounds like a fine idea, but it would also mean retiring the ReceivingMode enum altogether and letting clients perform the right operations themselves. I suppose Manager::sync_contacts would also have to go.

@Schmiddiii
Copy link
Contributor Author

I am fine with retiring ReceiveingMode and Manager::sync_contacts. Flare currently does not use any of those.

@ThatOneCalculator
Copy link

Please fix, as this lack of functionality can lead to detremental results. Ref: https://gitlab.com/schmiddi-on-mobile/flare/-/issues/202

@gferon gferon added this to the 0.7.0 milestone Apr 29, 2024
@gferon gferon self-assigned this Apr 29, 2024
@gferon gferon linked a pull request Nov 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants