Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle recaptchas when sending messages #176

Open
Schmiddiii opened this issue Jun 3, 2023 · 0 comments
Open

Handle recaptchas when sending messages #176

Schmiddiii opened this issue Jun 3, 2023 · 0 comments

Comments

@Schmiddiii
Copy link
Contributor

Sometimes one gets rate-limited when sending a message. presage should handle such cases and notify downstream applications that the user will need to submit a recaptcha and afterwards presage should retry sending the message.

Currently, once one gets an error when sending the message, and the message that should have been sent is lost forever.

Some design proposed by @gferon would be returning a future that could be polled and which can be used to re-send the message.

I would have proposed to store the message somewhere in the store and have a function to resend all failed messages. This would also help in cases where one sends messages without an internet connection (which Flare currently prevents, but I am sure one could race this and could happen either way). Another thing that may help (but which would require much greater changes) is to make the receive-message stream not only return messages but also status updates (in this case "please fill out captcha") instead of returning an error when sending a message (in this case it would be fine to return "Ok" as the message will be sent later).

Downstream issue on Flare: https://gitlab.com/Schmiddiii/flare/-/issues/81.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant