Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support partial contacts update requests #171

Open
julianfairfax opened this issue May 8, 2023 · 2 comments
Open

Support partial contacts update requests #171

julianfairfax opened this issue May 8, 2023 · 2 comments
Milestone
0.7.0

Comments

@julianfairfax
Copy link

Add support for requesting a partial contacts update from the main Signal device, to be used in clients such as Flare, for contact updates.
Schmiddiii added a commit to Schmiddiii/presage that referenced this issue May 19, 2023
@Schmiddiii
Set the expire timer
dcaca32 
This sets the expire timer of a message such that the current expiration
timer of a conversation stays the same (except in cases where it was
explicitly set to another value).

It may be a little counterproductive when sending a message to (e.g.) a
contact to query the timer for the thread which unwraps it back to
querying the contact, but this method may potentially also be used to
display the expiration timer.

Note that due to whisperfish#171, I would guess that the expiration timer always
stays the same for contacts directly after linking, e.g. changing it
on an official client and then sending a message from presage, presage
will set the expiration timer back to before the change.

This fixes whisperfish#93.
@Schmiddiii Schmiddiii mentioned this issue May 19, 2023
Merged
Schmiddiii added a commit to Schmiddiii/presage that referenced this issue Jun 6, 2023
@Schmiddiii
Set the expire timer
c1a246e 
This sets the expire timer of a message such that the current expiration
timer of a conversation stays the same (except in cases where it was
explicitly set to another value).

It may be a little counterproductive when sending a message to (e.g.) a
contact to query the timer for the thread which unwraps it back to
querying the contact, but this method may potentially also be used to
display the expiration timer.

Note that due to whisperfish#171, I would guess that the expiration timer always
stays the same for contacts directly after linking, e.g. changing it
on an official client and then sending a message from presage, presage
will set the expiration timer back to before the change.

This fixes whisperfish#93.
gferon pushed a commit that referenced this issue Jul 24, 2023
@Schmiddiii
Set the expire timer (#173)
54ef5c6 
This sets the expire timer of a message such that the current expiration
timer of a conversation stays the same (except in cases where it was
explicitly set to another value).

It may be a little counterproductive when sending a message to (e.g.) a
contact to query the timer for the thread which unwraps it back to
querying the contact, but this method may potentially also be used to
display the expiration timer.

Note that due to #171, I would guess that the expiration timer always
stays the same for contacts directly after linking, e.g. changing it
on an official client and then sending a message from presage, presage
will set the expiration timer back to before the change.

This fixes #93.
@gferon
Copy link
Collaborator

gferon commented Nov 19, 2023

Just to make sure I understand correctly, would that be similar to #98?

@gferon gferon added this to the 0.6.0 milestone Nov 19, 2023
@gferon gferon mentioned this issue Nov 19, 2023
Merged
@julianfairfax
Copy link
Author

julianfairfax commented Nov 20, 2023 •
edited
Loading

Just to make sure I understand correctly, would that be similar to #98?

I suppose yes. I was referring to how Signal-Desktop syncs the contacts on each launch though (which, since you can now also delete contacts, could be useful).

@gferon gferon modified the milestones: 0.6.0, 0.7.0 Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
2 participants
@gferon @julianfairfax