Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disappear messages after timer ends #168

Open
julianfairfax opened this issue May 3, 2023 · 7 comments
Open

Disappear messages after timer ends #168

julianfairfax opened this issue May 3, 2023 · 7 comments
Assignees
Milestone

Comments

@julianfairfax
Copy link

I know presage turns off disappearing messages when you send a message to a contact with them on. But, it would be nice if disappearing messages sent from other devices (and so leaving it on) would disappear when the timer ends. (Downstream issue: #69)

@julianfairfax
Copy link
Author

Basically a duplicate of #93

@julianfairfax
Copy link
Author

Now that #93 has been fixed by @Schmiddiii, this is an issue

@julianfairfax julianfairfax reopened this Jun 10, 2023
@julianfairfax
Copy link
Author

@gferon what would the difficulty be of implementing this now that #93 has been fixed?

@gferon
Copy link
Collaborator

gferon commented Aug 5, 2023

Not particularly hard, we can add a function that runs every second (or less often) and deletes expired messages.

@gferon gferon self-assigned this Aug 5, 2023
@Schmiddiii
Copy link
Contributor

I guess a cleaner solution would be to have a store-method that gets the next timestamp where a message needs to be deleted and repeatedly sleep to that point and delete. This could also be maybe put into a "maintainence queue" which e.g. deletes messages, resends failed messages (once failed messages are stored), .... Probably not as simple as repeatedly trying every second.

@baumkuchen42
Copy link

Hey, are there plans to work on this issue soon? I'm worried people might exploit this issue, to the detriment of their conversation partner.

@gferon
Copy link
Collaborator

gferon commented Apr 6, 2024

Hey, are there plans to work on this issue soon? I'm worried people might exploit this issue, to the detriment of their conversation partner.

Fair point, I'll see if I can get back to it soon.

@gferon gferon added this to the 0.7.0 milestone Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants