Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store reactions #123

Open
gferon opened this issue Mar 9, 2023 · 1 comment
Open

Store reactions #123

gferon opened this issue Mar 9, 2023 · 1 comment
Milestone

Comments

@gferon
Copy link
Collaborator

gferon commented Mar 9, 2023

Relating to #95, when we receive a reaction, we could either:

  • modify the original stored message (or store the reactions aside somewhere)
  • save the reaction without a reference to the original message
    and send back the result in the stream.

This will help apps not having to merge those events themselves when rendering.

@Schmiddiii
Copy link
Contributor

Schmiddiii commented Mar 9, 2023

I agree that this would be nice to have. Regarding the possible options:

modify the original stored message

I don't really think that would be nice, as the reaction-field for messages is for reacting for other messages and should probably not be abused for stroring reactions to the stored message. (Unless we want to introduce a completely new Message-type wrapping the DataMessage that will be stored (which may also be worth thinking about having nice wrappers instead of just the proto-things)).

store the reactions aside somewhere

I agree with that option the most. Maybe introduce a new tree for every thread mapping the message timestamp to a list of reactions or only one tree mapping a combination of thread and message timestamp to the list of reactions.

save the reaction without a reference to the original message and send back the result in the stream

Not sure what you exactly mean by that.

@gferon gferon changed the title Merge reactions with original message Store reactions Mar 19, 2023
@gferon gferon added this to the 0.6.0 milestone Apr 19, 2023
@gferon gferon modified the milestones: 0.6.0, 0.7.0 Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants