Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is checking document validity skipped sometimes? #9441

Open
mbrodesser-Igalia opened this issue Jun 19, 2023 · 1 comment
Open

Why is checking document validity skipped sometimes? #9441

mbrodesser-Igalia opened this issue Jun 19, 2023 · 1 comment
Labels
topic: popover The popover attribute and friends

Comments

@mbrodesser-Igalia
Copy link
Member

The calls from https://html.spec.whatwg.org/#hide-popover-algorithm to https://html.spec.whatwg.org/#check-popover-validity don't pass the document to https://html.spec.whatwg.org/#check-popover-validity, hence not checking it.

Some, not all, of the calls from https://html.spec.whatwg.org/#show-popover to https://html.spec.whatwg.org/#check-popover-validity check the document.

Might be related to #9367.

@mbrodesser-Igalia mbrodesser-Igalia added the topic: popover The popover attribute and friends label Jun 19, 2023
@josepharhar
Copy link
Contributor

We only check the document after script has potentially been run and could have moved the element to another document, which happens when we fire events.
Do you think that there are any missing spots which could actually affect the behavior?
Do you think that adding a note would make this better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: popover The popover attribute and friends
Development

No branches or pull requests

2 participants