Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to pass all the descendant of root to handle button invoker's top most popover ancestor #9164

Closed
cathiechen opened this issue Apr 13, 2023 · 2 comments
Labels
topic: popover The popover attribute and friends

Comments

@cathiechen
Copy link

https://html.spec.whatwg.org/multipage/popover.html#topmost-popover-ancestor

For each button invoker that is a descendant of newPopover's root, in tree order:

Here we need to pass all the descendants, it is not very effective for performance.
I tried to maintain a list of button invokers for each popover, but it does not work, especially the spec requires tree order.
Should we optimize this?
Any ideas? @jakearchibald @emilio @nt1m

@jakearchibald
Copy link
Contributor

Related: #9160
And discussion in the meeting today: https://www.w3.org/2023/04/13-openui-minutes.html#t03

@nt1m nt1m added the topic: popover The popover attribute and friends label Apr 13, 2023
@nt1m
Copy link
Member

nt1m commented Jun 6, 2023

Closing as I think this was fixed by #9171.

@cathiechen Please feel free to reopen if that's not the case.

@nt1m nt1m closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: popover The popover attribute and friends
Development

No branches or pull requests

3 participants