-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow fullscreen on already fullscreen elements without user activation #193
Comments
I just confirmed that Firefox work exactly like Chrome: if an |
This is the browser change that corresponds to this renderer change: https://chromium-review.googlesource.com/c/chromium/src/+/2970683 This spec change is filed here: whatwg/fullscreen#193 Bug: 1218483 Change-Id: I93337d9b74bb8475c631edb6f34b363510206a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2998308 Reviewed-by: Camille Lamy <[email protected]> Commit-Queue: enne <[email protected]> Cr-Commit-Position: refs/heads/master@{#898323}
This will allow an already fullscreen element to switch displays (with window-placement permission) without requiring an additional user activation. This is similar to how moveTo behaves. Filed here: whatwg/fullscreen#193 Bug: 1218483 Change-Id: Ia793eccb7e3f25492690c703025f7e975b597ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2970683 Reviewed-by: Mustaq Ahmed <[email protected]> Commit-Queue: enne <[email protected]> Cr-Commit-Position: refs/heads/master@{#897516} NOKEYCHECK=True GitOrigin-RevId: c17358d64ea9ee12cce4d136ac41dc7b1b90421c
I now feel like I misinterpreted the original request here: this is asking to drop the user activation requirement if Document.fullscreenElement is not null. FYI for @bradtriebwasser @michaelwasserman. |
Indeed, see supportive statements in this related comment thread on the PR adding user activation consumption to requestFullscreen. IMO, it seems totally reasonable to grant fullscreen element changes without user activation. |
One case I'm not sure about is nested fullscreen with iframes. If myblog.com embeds videohosting.com in an iframe and the user fullscreens a video in the iframe, myblog.com could later overlay or replace the video, although it couldn't mute and unmute the audio. If myblog.com is hostile there are already plenty of bad things it can do, but a seamless transition between the real videohosting.com and something else might be new. I'm not sure if this is important or not, but it would be good to look into. |
Yes, good catch that we need to avoid seamless fullscreen transition between two different origins. Perhaps we can say:
@foolip What do you think? Any chance an easier answer lies in the "relevant global object" in Step 5 above? The call |
@mustaqahmed well with |
In order to avoid issues with iframes, I think the simplest fix would be to require that there's no iframe on the fullscreen element stack. |
Could someone perhaps clarify the objectives from OP? And perhaps open a separate issue for the second paragraph as that seems rather separate? |
@quisquous can you elaborate on the motivation? |
It's okay to close this issue for now, and folks can reopen it if the need arises. The original motivation was moving a fullscreen element to another display of the device (by calling requestFullscreen with a new target screen in the FullscreenOptions dictionary, as supported by Chrome), when triggered by a click on a separate window. That was made possible via Capability Delegation of Fullscreen requests. Just FYI, @quisquous is no longer actively working in this space. |
@mustaqahmed requested that I file an issue for this.
In this text, I'm proposing that we add some text that requesting fullscreen on an already fullscreened element does not require nor consume user activation. This is currently how Chrome behaves, and so clarifying this text would be useful.
Additionally, as a part of window placement, we would like to extend
requestFullscreen
to have an additional screen parameter to open up fullscreen on a different display. Rerequesting fullscreen with a different screen will move the window to another screen (preserving fullscreen). Having this text would allow us to not require user activation for this behavior, solving this bug.The text was updated successfully, but these errors were encountered: