Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adoptNode() should always return a node #1006

Closed
TRowbotham opened this issue Aug 9, 2021 · 2 comments
Closed

adoptNode() should always return a node #1006

TRowbotham opened this issue Aug 9, 2021 · 2 comments

Comments

@TRowbotham
Copy link
Contributor

In the adoptNode() steps, step 3 says "If node is a DocumentFragment node whose host is non-null, then return.", but the interface defines adoptNode() as always returning a node. Shouldn't step 3 either return node or throw, or am I missing something from IDL that would allow returning nothing?

@annevk
Copy link
Member

annevk commented Aug 10, 2021

See #819.

@TRowbotham
Copy link
Contributor Author

I clearly forgot to use the search function, thanks for the context and sorry for the noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants