Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ethereumjs-abi breaks deployment without ssh #1047

Closed
1 task done
dcsan opened this issue Oct 6, 2022 · 3 comments
Closed
1 task done

bug: ethereumjs-abi breaks deployment without ssh #1047

dcsan opened this issue Oct 6, 2022 · 3 comments

Comments

@dcsan
Copy link

dcsan commented Oct 6, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Package Version

0.6.8

Current Behavior

see ethereumjs/ethereumjs-abi#67

crashes trying to install on any managed system that doesn't have .ssh keys available.
for me i found out on vercel, but assume its the same if you try to make a docker container, app engine, cloud func or similar.

because of deep dependency on a coinbase SDK that uses a

"git+ssh"

link, but that will fail without any key present.

the solution might be to try and update the dependencies?

yarn why ethereumjs-abi
yarn why v1.22.19
[1/4] 🤔  Why do we have the module "ethereumjs-abi"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "[email protected]"
info Reasons this module exists
   - "wagmi#@coinbase#wallet-sdk#eth-json-rpc-filters#eth-json-rpc-middleware#eth-sig-util" depends on it
   - Hoisted from "wagmi#@coinbase#wallet-sdk#eth-json-rpc-filters#eth-json-rpc-middleware#eth-sig-util#ethereumjs-abi"
info Disk size without dependencies: "456KB"
info Disk size with unique dependencies: "780KB"

Expected Behavior

can install /deploy without fail

Steps To Reproduce

try to deploy client on vercel / nextJS

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)

no because

Anything else?

deep dependency pain

@tmm
Copy link
Member

tmm commented Oct 9, 2022

Hey! Not sure about your specific set up, but we have no issue with Vercel for the wagmi docs site. This unfortunately seems like it needs to be solved upstream in either ethereumjs-abi or coinbase-wallet-sdk.

@tmm tmm closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2022
@IvanZen
Copy link

IvanZen commented Oct 15, 2022

Same issue with yarn. But all fine with npm.

Copy link
Contributor

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest wagmi version. If you have any other comments you can create a new discussion.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants