Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imprv: ROM users can manage comments #9101

Open
wants to merge 17 commits into
base: dev/7.1.0
Choose a base branch
from

Conversation

WNomunomu
Copy link
Contributor

@WNomunomu WNomunomu commented Sep 12, 2024

タスク

  • #122312 [Read Only User] ROM user がコメント操作できる

概要

  • ROM user がコメント操作できるかどうかを global settings として管理画面から設定できるようにしました。
  • コメント操作が許可されている場合は、ROM user もコメント操作できるようにしました。

変更点

  • isRomUserAllowedToComment を新しく security-settings に設定できるように変更
  • validation の実装、置換
  • NotAvailableIfReadOnlyUserNotAllowedToComment コンポーネントの実装
  • 翻訳データの追加

セルフチェック

  • コンフリクト解消したか
  • 余計なコードは残っていないか
  • 適切にメモ化したか
  • 責務の問題はクリアしているか
  • CIは通っているか
  • PRの内容は適切にかけているか

Copy link

changeset-bot bot commented Sep 12, 2024

⚠️ No Changeset found

Latest commit: 203ddb2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PageItemControl.spec.tsx を参考に、コンポーネントテストを書いてください
(後続タスクで構わない)

@yuki-takei yuki-takei changed the base branch from master to dev/7.1.0 September 16, 2024 09:09
@yuki-takei yuki-takei changed the title imprv: implement so that rom users can manage comments imprv: ROM users can manage comments Sep 16, 2024
mergify bot added a commit that referenced this pull request Sep 16, 2024
mergify bot added a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants