Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump shrinkwrap.resolver.version from 3.3.0 to 3.3.2 #3070

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 1, 2024

Bumps shrinkwrap.resolver.version from 3.3.0 to 3.3.2.
Updates org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-impl-maven from 3.3.0 to 3.3.2

Release notes

Sourced from org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-impl-maven's releases.

3.3.2

Shrinkwrap Resolver - 3.3.2

Full Changelog: shrinkwrap/resolver@3.3.1...3.3.2

Resolved issues

Chores

Component upgrades

3.3.1

Shrinkwrap Resolver - 3.3.1

Full Changelog: shrinkwrap/resolver@3.3.0...3.3.1

Resolved issues

... (truncated)

Commits
  • 286b146 [maven-release-plugin] prepare release 3.3.2
  • 0aaa879 [maven-release-plugin] rollback the release of 3.3.2
  • 7512c6e [maven-release-plugin] prepare release 3.3.2
  • 900507f Merge pull request #354 from shrinkwrap/dependabot/maven/org.apache.maven.plu...
  • 06df9db Merge pull request #357 from shrinkwrap/dependabot/maven/org.junit.jupiter-ju...
  • e167b10 Bump org.junit.jupiter:junit-jupiter from 5.11.2 to 5.11.3
  • 31a7957 Bump org.apache.maven.plugins:maven-invoker-plugin from 3.8.0 to 3.8.1
  • 953b648 Merge pull request #340 from flowlogix/local-resolver
  • 7a4a847 chore: add Java 17 build to CI
  • eeec756 deps: update various maven components to latest
  • Additional commits viewable in compare view

Updates org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-spi from 3.3.0 to 3.3.2

Release notes

Sourced from org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-spi's releases.

3.3.2

Shrinkwrap Resolver - 3.3.2

Full Changelog: shrinkwrap/resolver@3.3.1...3.3.2

Resolved issues

Chores

Component upgrades

3.3.1

Shrinkwrap Resolver - 3.3.1

Full Changelog: shrinkwrap/resolver@3.3.0...3.3.1

Resolved issues

... (truncated)

Commits
  • 286b146 [maven-release-plugin] prepare release 3.3.2
  • 0aaa879 [maven-release-plugin] rollback the release of 3.3.2
  • 7512c6e [maven-release-plugin] prepare release 3.3.2
  • 900507f Merge pull request #354 from shrinkwrap/dependabot/maven/org.apache.maven.plu...
  • 06df9db Merge pull request #357 from shrinkwrap/dependabot/maven/org.junit.jupiter-ju...
  • e167b10 Bump org.junit.jupiter:junit-jupiter from 5.11.2 to 5.11.3
  • 31a7957 Bump org.apache.maven.plugins:maven-invoker-plugin from 3.8.0 to 3.8.1
  • 953b648 Merge pull request #340 from flowlogix/local-resolver
  • 7a4a847 chore: add Java 17 build to CI
  • eeec756 deps: update various maven components to latest
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from manovotn as a code owner November 1, 2024 11:05
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Nov 1, 2024
@manovotn
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/master/shrinkwrap.resolver.version-3.3.2 branch from c8ec058 to 5019dbf Compare November 12, 2024 12:58
Bumps `shrinkwrap.resolver.version` from 3.3.0 to 3.3.2.

Updates `org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-impl-maven` from 3.3.0 to 3.3.2
- [Release notes](https://github.com/shrinkwrap/resolver/releases)
- [Commits](shrinkwrap/resolver@3.3.0...3.3.2)

Updates `org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-spi` from 3.3.0 to 3.3.2
- [Release notes](https://github.com/shrinkwrap/resolver/releases)
- [Commits](shrinkwrap/resolver@3.3.0...3.3.2)

---
updated-dependencies:
- dependency-name: org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-impl-maven
  dependency-type: direct:development
  update-type: version-update:semver-patch
- dependency-name: org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-spi
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/master/shrinkwrap.resolver.version-3.3.2 branch from 5019dbf to 3833c26 Compare November 12, 2024 13:00
@manovotn
Copy link
Contributor

This failure seems familiar too what happened in #3023 (comment)
Probably a were similar issue with a transitive dependency being taken from a wrong artifact.
I'll need to take a closer look into where it's coming from.

@manovotn
Copy link
Contributor

Alright, this is slightly different.
The missing artifact was actually only present because it was transitively brought through shrinkwrap and then through maven dependencies:

[INFO] +- org.apache.maven:maven-model-builder:jar:3.9.3:compile
[INFO] |  +- org.apache.maven:maven-artifact:jar:3.9.3:compile
[INFO] |  |  \- org.apache.commons:commons-lang3:jar:3.12.0:compile

Newer Shrinkwrap uses newer versions of these (3.9.3 -> 3.9.9) and those no longer have the commons-lang3 dep.
That being said, the failing test probably doesn't even need the dependency to begin with - it is only used to workaround a timeout we were getting years ago when CI ran on Jenkins and it might easily no longer be a problem.

@manovotn manovotn merged commit b0ae7f1 into master Nov 12, 2024
12 checks passed
@manovotn manovotn deleted the dependabot/maven/master/shrinkwrap.resolver.version-3.3.2 branch November 12, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant