Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual mode rework #209

Open
jayktaylor opened this issue Jan 31, 2024 · 3 comments
Open

Manual mode rework #209

jayktaylor opened this issue Jan 31, 2024 · 3 comments
Labels
calc Issue affects the core calculator code epic Major, usually ongoing task ops ui Issue affects the UI/React code

Comments

@jayktaylor
Copy link
Member

Currently, manual mode can be enabled by clicking some text in the footer of the page. This does the following:

  • Enables manual mode and saves the state of that toggle in your browser's window.localStorage
  • Allows users to edit their equipment bonuses manually
    • Also, adds a button to re-calculate bonuses from equipment (which is the standard behaviour without manual mode on)
  • Allows users to edit their monster's stats manually

This is a bit of a janky way to approach this, but for the most part works for that session. However, this is probably a less than ideal user experience for power users, and also suffers from a bug where opening a shortlink that has manual stats doesn't really work as you'd expect (resets the numbers changed in manual mode).

Proposal

  • Remove the concept of a "manual mode"
  • Add the ability to select a "custom" monster from the monster dropdown, which allows the player to "create their own" monster (functionality that currently exists in manual mode)
  • Add something to allow players to edit their equipment bonuses(???) if enabled
  • Ensure that the data from both custom monster/custom equipment is sent with the shortlink payload, so it persists when someone else loads the shortlink
@jayktaylor jayktaylor added calc Issue affects the core calculator code ui Issue affects the UI/React code ops epic Major, usually ongoing task labels Jan 31, 2024
@SuperNerdEric
Copy link
Contributor

Some feedback:

  • Setting a monster to a specific defence level currently is a little unintuitive. If you want to set their defence to 0 you have to enter in a bunch of BGS damage.
  • If you want to set a monster to a specific HP currently the box only pops up if you equip ruby bolts (e) with a proper crossbow. I find this a little unintuitive.
  • You may not even want to use a custom monster because there's some special effect tied to that monster / attributes like draconic.
  • If there's a custom monster it should probably be at the top of the list and not alphabetical.

As a user it feels like to me that editing a monster's stats should work in the reverse way player skills work. So that the left side is editable, but the right side is not.
image

@SuperNerdEric
Copy link
Contributor

SuperNerdEric commented Feb 1, 2024

Another thought: If there's ever an oversight (like Warden's P4), update, bug, etc with a monster's stats letting the user customize that specific monster's stats is a helpful workaround until it is properly fixed / accounted for.

@jayktaylor
Copy link
Member Author

I've added a "custom monster" dropdown option in 80e66e2 (currently only on the staging site). As a result, the "manual mode" toggle no longer lets you edit the monster inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calc Issue affects the core calculator code epic Major, usually ongoing task ops ui Issue affects the UI/React code
Projects
None yet
Development

No branches or pull requests

2 participants