Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support thralls #204

Open
SuperNerdEric opened this issue Jan 31, 2024 · 0 comments · Fixed by #229
Open

Support thralls #204

SuperNerdEric opened this issue Jan 31, 2024 · 0 comments · Fixed by #229
Labels
calc Issue affects the core calculator code feature request ui Issue affects the UI/React code

Comments

@SuperNerdEric
Copy link
Contributor

What feature would you like to see?

It seems to be a common request to support thralls added to your DPS. This is a common feature in other DPS calculators.

Evidence

No response
@jayktaylor jayktaylor added calc Issue affects the core calculator code ui Issue affects the UI/React code and removed triage labels Jan 31, 2024
@MarkKoester MarkKoester mentioned this issue Feb 1, 2024
Closed
@jayktaylor jayktaylor linked a pull request Feb 1, 2024 that will close this issue
Add use thrall option #213
Closed
LlemonDuck added a commit that referenced this issue Feb 5, 2024
@LlemonDuck @MarkKoester
add thrall damage support
2554cfc 
closes #204
closes #213

Co-authored-by: Mark Koester <[email protected]>
@LlemonDuck LlemonDuck mentioned this issue Feb 5, 2024
Merged
LlemonDuck added a commit that referenced this issue Feb 5, 2024
@LlemonDuck @MarkKoester
add thrall damage support
ebeac41 
closes #204
closes #213

Co-authored-by: Mark Koester <[email protected]>
LlemonDuck added a commit that referenced this issue Feb 5, 2024
@LlemonDuck @MarkKoester
add thrall damage support
3ccc835 
closes #204
closes #213

Co-authored-by: Mark Koester <[email protected]>
@jayktaylor jayktaylor reopened this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
calc Issue affects the core calculator code feature request ui Issue affects the UI/React code
Projects
None yet
Milestone
No milestone
2 participants
@jayktaylor @SuperNerdEric