Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: comment when auto merge/hardreset fails #231

Open
wei opened this issue Aug 22, 2020 · 6 comments
Open

feat: comment when auto merge/hardreset fails #231

wei opened this issue Aug 22, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@wei
Copy link
Owner

wei commented Aug 22, 2020

Currently GitHub returns an error when Pull tries to merge into a protected branch. The PR will just stay open ready to be manually merged.

An improvement will be commenting on the PR when this happens.

@wei wei added the enhancement New feature or request label Aug 22, 2020
@wei wei changed the title feat: comment when the base branch is a protected branch feat: comment when auto merge/hardreset fails Aug 22, 2020
Repository owner deleted a comment Sep 11, 2020
@wei
Copy link
Owner Author

wei commented Sep 15, 2020

One reason PRs fail to be merged automatically is due to changes in .github/workflows files (GitHub Apps do not have write access to it)

@jefferycline1
Copy link

😀

@joshiayush
Copy link

@wei Assign it to me.

@wei wei assigned joshiayush and unassigned joshiayush Jan 16, 2022
Repository owner deleted a comment Feb 17, 2022
@ddelange
Copy link

hi @wei 👋

are there other scenarios in which a pull doesn't auto-merge? i do not have branch protection enabled and this PR from yesterday (first one since I added pull.yml) is still open 🤔

@ddelange
Copy link

oh and now (9hrs after opening) the PR merges. maybe I spoke too soon. is that a normal time frame?

@wei
Copy link
Owner Author

wei commented Sep 30, 2022

Hiiii @ddelange thanks for using Pull. Due to the large amount of repos using pull and the unpredictability timeframe for GitHub to mark a PR as mergeable, this timeframe is not abnormal. This issue we are on is for a new feature unrelated to your inquiry. Please open a new issue or comment on a more relevant issue if you have further questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants