Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify add/remove_track arguments for peer connections #523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

w-utter
Copy link

@w-utter w-utter commented Jan 1, 2024

Previously, RTCPeerConnection's remove_track took a &Arc<RTCRtpSender> while its add_track took an Arc<dyn TrackLocal + Send + Sync> for its argument, and semantically it makes sense for these two methods to have the same parameters.

This would delegate checking whether the track exists on a given sender to the user before removing the track (as seen in the changes to the example), but I think its rare that a user would want to remove a track based on the sender rather than explicitly specifying the track.

@rainliu
Copy link
Member

rainliu commented Feb 10, 2024

why didn't this RP trigger github actions Checks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants