[interceptor] control max packet age for NACK responses #313
Conversation
k0nserv
force-pushed
the
add-nack-responder-max-packet-age
branch
from
5612d59
to
8c869b4
Compare
k0nserv
force-pushed
the
add-nack-responder-max-packet-age
branch
from
e22f3a4
to
5572970
Compare
Codecov ReportBase: 59.87% // Head: 59.87% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #313 +/- ##
=======================================
Coverage 59.87% 59.87%
=======================================
Files 503 503
Lines 47644 47644
Branches 12357 12357
=======================================
Hits 28528 28528
Misses 9889 9889
Partials 9227 9227 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| pub async fn written_rtp(&self) -> Option<rtp::packet::Packet> { | ||
| let mut rtp_out_modified_rx = self.rtp_out_modified_rx.lock().await; | ||
| rtp_out_modified_rx.recv().await | ||
| } | ||
|
|
||
| /// Assert that a RTP packet has traversed interceptor chains. | ||
| /// | ||
| /// Like [`writte_rtp`] but does not wait. |
There was a problem hiding this comment.
| /// Like [`writte_rtp`] but does not wait. | |
| /// Like [`written_rtp`] but does not wait. |
melekes
changed the title
k0nserv
force-pushed
the
add-nack-responder-max-packet-age
branch
from
5572970
to
5302015
Compare
|
@k0nserv any plan on merging this any time soon? I think we're also hitting the edge case of retransmissions aggravating the problem |
|
I also wonder how receivers handle the case where certain nacks are ignored. E.g. I've seen Chrome sending the same nack over and over. |
|
@k0nserv anything left to do here except (a) rebase (b) fix conflicts ? thanks 🙏 |
|
I don't believe so |
TODO: