Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Replay Bug]: Encoding of URL parameter &section to §ion prevents page from being displayed #323

Open
Ben754444 opened this issue May 22, 2024 · 3 comments
Labels
bug Something isn't working replay bug Archived content is not displaying as expected repro needed

Comments

@Ben754444
Copy link

Ben754444 commented May 22, 2024

ReplayWeb.page Version

v2.0.0

What did you expect to happen? What happened instead?

When viewing a page with "&sect" in the URL, the site will convert the "&sect" into the character §, which then errors as it cannot find the page.

image

In this image, the correct URL is shown in the page list and URL bar. The incorrect URL is shown on the error page.

Additionally, using &amp does not seem to work either despite the correct URL being shown:

image

Step-by-step reproduction instructions

  1. Archive a page with "&sect" in the URL
  2. Open in ReplayWeb and navigate to the page
  3. Observe a 404 page despite the fact that it is in the archive

Additional details

Note: this happens with basically any unicode character, for example: &#128514

@Ben754444 Ben754444 added bug Something isn't working replay bug Archived content is not displaying as expected labels May 22, 2024
@ikreymer
Copy link
Member

ikreymer commented Jun 8, 2024

Can you provide a specific example where this happens? You can email us directly if you don't want to make it public.
I tried archiving and replaying https://example.com/?a=b&section=0 using archiveweb.page and it worked fine

@ikreymer ikreymer closed this as completed Jun 8, 2024
@ikreymer ikreymer reopened this Jun 8, 2024
@ikreymer
Copy link
Member

ikreymer commented Jun 8, 2024

I was able to repro the error in the escape error in the 404 page, but not the actual loading.

@Ben754444
Copy link
Author

Hey, I don't have access to the original archive right now sorry. From what I remember, it starts when you navigate from a page using a button on the actual site. So I assume it might be to do with href/setting the URL using JS. Once you've encountered the broken version once, it remains despite using the side panel.

Should be able to get the file on Wednesday and then I'll try send you a copy without any sensitive info in.

ikreymer added a commit to webrecorder/wabac.js that referenced this issue Jun 9, 2024
- escape URL on not found page, partial fix for webrecorder/replayweb.page#323
- hashiterator: more efficient use of createSHA256(), init on first use, unreference when done, catch error on init
ikreymer added a commit to webrecorder/wabac.js that referenced this issue Jun 9, 2024
- escape URL on not found page, partial fix for webrecorder/replayweb.page#323
- hashiterator: more efficient use of createSHA256(), init on first use, unreference when done, catch error on init
ikreymer added a commit to webrecorder/wabac.js that referenced this issue Jun 9, 2024
- escape URL on not found page, partial fix for webrecorder/replayweb.page#323
- hashiterator: more efficient use of createSHA256(), init on first use, unreference when done, catch error on init
ikreymer added a commit that referenced this issue Jun 10, 2024
Fidelity improvements (via wabac.js and wombat):
- fixes ebay carousel #326 (via wombat)
- partial fix to error page escaping #323 (via wabac)
- fixes to reddit pages #317 
- fixes to twitter/x replay (via wabac / wombat)

Build improvements:
- run mkdocs gh-deploy --force in gh action, instead of publish-docs to avoid accidental updates
- auto install ruffle from download script, remove from git, add 'update-ruffle' script
- update to latest ruffle which doesn't inject setImmeidate/ clearImmediate to avoid interference with certain sites, fixing fidelity on some sites (including twitter/x)
- remove unused src/sw.ts
- deps: wabac.js to 2.18.2

bump to 2.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working replay bug Archived content is not displaying as expected repro needed
Projects
None yet
Development

No branches or pull requests

2 participants