Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_readers.clj default #4

Open
vemv opened this issue Jul 20, 2021 · 2 comments
Open

data_readers.clj default #4

vemv opened this issue Jul 20, 2021 · 2 comments

Comments

@vemv
Copy link

vemv commented Jul 20, 2021

As the README notes, data_readers.clj is a common case for a resource name that can be repeated.

Checking out https://clojure.org/reference/reader#tagged_literals , that appears to be expected.

Would you consider adding it to the default set of excluded resource names?

Thanks - V

@vemv
Copy link
Author

vemv commented Jul 20, 2021

Same for COPYRIGHT e.g.

COPYRIGHT -- 2  collisions:
  -- /Users/vemv/.m2/repository/com/cognitect/http-client/0.1.106/http-client-0.1.106.jar
  -- /Users/vemv/.m2/repository/com/cognitect/anomalies/0.1.12/anomalies-0.1.12.jar

seems close enough in spirit to current default files

@bendlas
Copy link
Contributor

bendlas commented Jul 21, 2021

Yep, I think I created this plugin before learning about the merging behavior of tagged literals. Thanks for bringing it up! Including COPYRIGHT into default exclusions also seems like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants