Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tables wider #5187

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Make tables wider #5187

merged 2 commits into from
Nov 15, 2024

Conversation

Bestem0r
Copy link
Contributor

Description

Increases the company table widths to utilize more screen estate.

Result

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.
Before After
image image

Testing

  • I have thoroughly tested my changes.

Resolves ABA-1048

@linear Linear
Copy link

linear bot commented Nov 13, 2024

ABA-1190 Increase table width on company page

ABA-1048 Improve BDB

@vercel Vercel
Copy link

vercel bot commented Nov 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 11:10am

@github-actions github-actions bot added the review-needed Pull requests that need review label Nov 13, 2024
eikhr
eikhr approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@eikhr eikhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very pro!

ivarnakken
ivarnakken requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea!

app/routes/bdb/components/BdbDetail.tsx Outdated Show resolved Hide resolved
@ivarnakken ivarnakken added enhancement Pull requests that make enhancements, instead of just purely new features approved Pull requests that have been approved labels Nov 15, 2024
danielyanghansen
danielyanghansen approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@danielyanghansen danielyanghansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! 👍

falbru
falbru approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@Bestem0r Bestem0r merged commit 0f70cb4 into master Nov 15, 2024
8 checks passed
@Bestem0r Bestem0r deleted the fix-company-tables branch November 15, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch0rizo ch0rizo ch0rizo approved these changes

@ivarnakken ivarnakken ivarnakken approved these changes

@falbru falbru falbru approved these changes

@danielyanghansen danielyanghansen danielyanghansen approved these changes

@itsisak itsisak itsisak approved these changes

@eikhr eikhr eikhr approved these changes

Assignees
No one assigned
Labels
approved Pull requests that have been approved enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Bestem0r @eikhr @itsisak @danielyanghansen @falbru @ivarnakken @ch0rizo