Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix registration modal pool styling #5000

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix registration modal pool styling #5000

merged 1 commit into from
Sep 25, 2024

Conversation

ch0rizo
Copy link
Contributor

@ch0rizo ch0rizo commented Sep 25, 2024 •
edited
Loading

Description

It overflowed weird so I fix

Result

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.

Caution

Make sure your images do not contain any real user information.

Before After
Screenshot 2024-09-25 at 21 43 12 Screenshot 2024-09-25 at 21 42 54

Testing

  • I have thoroughly tested my changes.

Resolves ABA-1086

@ch0rizo ch0rizo added review-needed Pull requests that need review bug-fix Pull requests that fix a bug small-fix Pull requests that fix something small labels Sep 25, 2024
@linear Linear
Copy link

linear bot commented Sep 25, 2024

ABA-1086 Fix registration modal pool styling

@vercel Vercel
Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Sep 25, 2024 7:58pm

eikhr
eikhr approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@eikhr eikhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🤩

jonasdeluna
jonasdeluna approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@jonasdeluna jonasdeluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@ch0rizo ch0rizo merged commit 4b3522e into master Sep 25, 2024
6 checks passed
@ch0rizo ch0rizo deleted the fix-registration-modal-styling branch September 25, 2024 20:07
ivarnakken
ivarnakken reviewed Sep 25, 2024
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome😍😍This has annoyed me for so long!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarnakken ivarnakken ivarnakken left review comments

@eikhr eikhr eikhr approved these changes

@jonasdeluna jonasdeluna jonasdeluna approved these changes

Assignees
No one assigned
Labels
bug-fix Pull requests that fix a bug review-needed Pull requests that need review small-fix Pull requests that fix something small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ch0rizo @eikhr @ivarnakken @jonasdeluna