Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

fix: mink-selenium2-driver:1.3.x-dev no longer exists #13

Closed
wants to merge 2 commits into from

Conversation

alexxed
Copy link

@alexxed alexxed commented Sep 2, 2019

Replaced with 1.4.x-dev

minkphp/MinkSelenium2Driver#311

@timmillwood
Copy link

This is not a good fix, it'll fail when the branch alias changes to 1.5.x. We should use ~1.3 or dev-master.

#14

@alexxed
Copy link
Author

alexxed commented Sep 2, 2019

Of course; but it's critical now and I see no other quick fix available right now:

  • 1.3.1 is from 2016, I assume whoever put it on dev wanted something more than that
  • 1.4.0 is not yet available on packagist

@upchuk
Copy link

upchuk commented Sep 2, 2019

Related minkphp/MinkSelenium2Driver#313

@timmillwood
Copy link

if it's critical use ~1.3 or dev-master

@timmillwood
Copy link

IIRC master-dev doesn't work, it should be dev-master.

@alexxed
Copy link
Author

alexxed commented Sep 2, 2019

Right; that works for me. It would be quicker though if minkphp/MinkSelenium2Driver#313 fixes it.

@upchuk
Copy link

upchuk commented Sep 2, 2019

The 1.3 branch will be added back minkphp/MinkSelenium2Driver#313

@alexxed
Copy link
Author

alexxed commented Sep 2, 2019

ok, then let's close this and open when 1.4.0 is available on packagist.

@alexxed alexxed closed this Sep 2, 2019
@BaluErtl
Copy link

BaluErtl commented Sep 2, 2019

"The 1.3 branch will be added back minkphp/MinkSelenium2Driver#313"

Regarding @stof's most recent reply on that thread it doesn't seem like for me that will happen soon on Mink's side:

"it would be good if webflo/drupal-core-require-dev could fix their mess instead of forcing us to create our own mess to workaround it. You are asking the Mink maintainers to fix a situation they are not responsible for at all here. And anyway, I won't have time to do that right now (and if I had time to work on Mink right now, I would still rather work on preparing things for a next release than working on such workaround)."

@alexxed
Copy link
Author

alexxed commented Sep 2, 2019

Right, than this still makes sense if a release can happen shortly here.

@BaluErtl
Copy link

BaluErtl commented Sep 6, 2019

Yesterday Mink's @aik099 was kind enough to re-create 1.3 branch (see comment), so now I'm a bit unsure whether webflo/drupal-core-require-dev package should change to dev-master or not?

@rodrigoaguilera
Copy link

Clearly not, this can be closed

@greg-1-anderson
Copy link

Existing tags on this project should continue to work. New tags on this project will adopt whatever version constraint appears in Drupal. Hopefully we will be on ^1.4 by the time 8.7.8 comes out. If not, remaining on 1.3.x-dev is the right thing to do.

@alexxed alexxed closed this Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants