-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(calendar): Detect orientation and change scrollMode #356
base: master
Are you sure you want to change the base?
Conversation
Could you give me a hand / ideas / opinions @RichardLindhout?. Thanks |
I think we could reduce states by useWindowDimensions hook and not use state's at all. I'm not sure why the layout won't change do we have hardcoded width somewhere maybe? |
|
|
What about tablets we only need to change scrollMode if height is not enough right? |
I think te problem is here: Does the onLayout get called is device is rotated? |
I think the swiper.native.ts + Autosizer have some problems maybe on rotate? |
Thanks for your reply. I didn't check in tablets because I don't have Thanks again |
Fix #355.
Read below⚠️
POSSIBLE SOLUTION AT THE MOMENT
Is not 100% ok, we should improve it. I was able to made scrollable the calendar and works perfectly If you are in mode
portrait
all time or if you are in modelandscape
all time. But if you open the modal inportrait
and you rotate tolandscape
the scroll will works, but the layout will breaks.@RichardLindhout I hope can help us to solve this problem.
Layout when you change from
portrait
tolandscape
.Layout when you change from
landscape
toportrait
.