Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple import maps #49004

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 6, 2024

Import maps currently have to load before any ES module and there can
only be a single import map per document. That makes them fragile and
potentially slow to use in real-life scenarios: Any module that loads
before them breaks the entire app, and in apps with many modules the
become a large blocking resource, as the entire map for all possible
modules needs to load first.

This implements whatwg/html#10528 to solve that.

Change-Id: I54e1b9cdfe989d61c85d73a5fd384f860273ad9a
Bug: 358379381
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5776262
Commit-Queue: Yoav Weiss (@Shopify) <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1378943}

Import maps currently have to load before any ES module and there can
only be a single import map per document. That makes them fragile and
potentially slow to use in real-life scenarios: Any module that loads
before them breaks the entire app, and in apps with many modules the
become a large blocking resource, as the entire map for all possible
modules needs to load first.

This implements whatwg/html#10528 to solve that.

Change-Id: I54e1b9cdfe989d61c85d73a5fd384f860273ad9a
Bug: 358379381
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5776262
Commit-Queue: Yoav Weiss (@Shopify) <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1378943}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 3f26764 into master Nov 6, 2024
25 checks passed
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-5776262 branch November 6, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants