-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interop 2024 Accessibility Investigation #90
Comments
Note: I tweaked the numbers above a bit since the time of the call this morning to account for the two items now marked as 3% each. I also added all the "candidate" issues to the final 10% item. |
I'd like to understand the reason we're looking at prototyping both tree dump and Accessible Node. It seems to me that the concept of Accessible Node is more flexible: you can implement a tree dump framework using Accessible Node (by walking all nodes from JS, likely packaged into a nice utility module), whereas you can't really implement Accessible Node using a tree dump. Tree dump also seems like it might be less flexible and more challenged by the tree structure differences between engines, which, while mostly inconsequential to users and AT, will be very troublesome in tests. Is there some context written down somewhere that could help me understand better? Thanks. |
As I understand it, Google & Bocoup wanted to prototype the tree dump for the dual purpose of 1. syncing WebDriver and CDP accessors to that feature, and 2. That it will allow some limited amount of WPT testing potentially more quickly the other path. For example, though the output trees may be slightly different, substring searches on leaf nodes could allow us to test things like the Since it's an investigation (not a Focus Area), I don't think there's any harm in exploring that path. Currently it's blocked because the investigators (@mzgoddard, @boazsender, etc) have not yet addressed the RFC guidance in this comment. If that happens, we can continue the exploration. If not, that's okay too. |
Minor note: we are at 1% or 2%, so we could get the investigation score off the ground, but I'm not really worried about updating it until we hit the 5% or 10% mark. |
@cookiecrook you mean we would not hit 100%, right? From Gecko's point of view, since we don't already have a tree dump API, we're reluctant to invest time into implementing two things instead of one. |
Responding to a few different threads in this issue: Next steps for tree dumping:
We no longer think that landing the chromium prototype is the right next step. We did start an RFC conversation, which ultimately led to this new direction. I think we should update the roadmap above to reflect this. Perhaps our 2024 scope should be the specs, and not the implementation. @zcorpan would Gecko consider implementing tree dumping in 2025 if there were specs? Next steps for accessible nodes: Pursuing two testing paths:
@jcsteh et al, do you think specing and testing parts of trees and along with accessible nodes would improve ARIA rendering interop? |
A few replies to @boazsender:
As Gecko doesn't support tree dump functionality and WebKit doesn't support webdriver bidi, this path may not enable near-term testing in anything besides Chromium. IMO, if this is to kept on the Investigation roadmap, at least one of those variables should change to support testing this year in at least two implementations.
I think AOM #197 & AOM #203 may be a more likely path toward standardizing... I thought the goal of the tree dump was effectively a temporary stand-in API that might enable testing sooner than the longer-term interoperable web driver APIs.
AOM or ARIA I think... but isn't that what AOM #203 would standardize? We know there are tree differences, so aligning parent/child returns
Since all engines support webdriver classic, isn't that the better near term approach? Nothing in the AOM #203 proposal prevents longer-term adoption into webdriver bidi. It even mentions certain features (live region testing, for example) should be deferred until bidi support is universal. |
Why would this be faster with tree dump vs ~AccessibleNode? Either way, we will (for now) need to potentially fuzzy match things to make it work across browsers. As I understand it, either approach exposes a bunch of properties for a given node. It's just that tree dump exposes them for all nodes, whereas ~AccessibleNode exposes them for a single node (and you then walk to other nodes to query those). |
~AccessibleNode would be known list of standardized, normalized properties that all implementations approve, not the entirety of each implementation's internal representation. In contrast, the tree dump path would just be a standardized accessor to a serialized, non-standard, engine internal representation... In Chrome and WebKit, those internal tree accessors already exist as It'd be more work to normalized the tests to accept substring variants of the same info from different engines ( |
I wrote this:
backtracking a bit since @zcorpan said above:
Completely reasonable. In any case, the point is moot until someone makes progress on the Chrome prototype. If that ends up being abandoned (or if Gecko stakeholders feel strongly enough to object), we can pull it from the scoring criteria, too. For what it's worth, my priority and focus is also on the |
Based on the group consensus in today's meeting, I've adjusted the scoring criteria significantly above... The most significant change (abandonment of the serialized tree dump) is called out specifically. Please comment, change, or otherwise let me know if you have any questions or concerns. |
score updated: 20*(6/17) + 5 = 12% |
Current score: 20*(6/13) + 15 = 24.231% 🎉 |
Should we bring in @spectranaut and @alice's work on the Acacia AAM testing in the scoring criteria for the 2024 Accessibility Investigation? They made significant progress recently and including it would bring the RFC more visibility. |
We resolved to drop these in #140 (comment) |
Yes per #140 (comment) |
Scoring Criteria updated per meeting resolution: Add Acacia, and drop the proposed DRI-less miscellaneous issues. |
5 + 30 + 20*(7/13) = 45.769% |
5 + 10 + 30 + 20*(7/13) = 55.769% |
Separate from the Interop 2024 Accessibility Focus Area, we'll also have an investigation area that doesn't contribute to the overall Interop 2024 score.
Scoring Criteria for Interop 2024 Accessibility Testing Investigation
[Significant Edit May 7, 2024] The Accessibility Investigation Group, in a meeting today and based on the culmination of discussion below, determined to abandon the Serialized Accessibility Tree Dump path in favor of a tree walker investigation using the Accessible Node direction. The 25% scoring criteria previously dedicated to Tree Dump is now repurposed into the Accessible Node investigation, including Tree Walking features.
(25%) Accessible Node or similar API
tentative
) that purposefully avoid all known tree implementation differences (scroll areas, pseudo elements and other generated content, etc.)tentative
) that expose the areas where the internal accessibility tree differ between engines(25%) Acacia AAM test exploration (DRI @spectranaut)
(30%) Documentation
(20%) Miscellaneous
aria-hidden
using label/role where possible #91Carryover 2025 Investigation
The text was updated successfully, but these errors were encountered: