Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: build uses latest branch code instead of specified commit in ci/cd #7850

Open
shulaoda opened this issue Sep 10, 2024 · 4 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@shulaoda
Copy link
Collaborator

shulaoda commented Sep 10, 2024

Details

Related to #7757

In fact, the actual modification of trait Dependency is made in the latest main branch, not the branch where the build is located.

   Compiling rspack_plugin_javascript v0.1.0 (/build/crates/rspack_plugin_javascript)
error[E0407]: method `span` is not a member of trait `Dependency`
  --> crates/rspack_plugin_javascript/src/dependency/context/require_resolve_context_dependency.rs:45:3
   |
45 | /   fn span(&self) -> Option<ErrorSpan> {
46 | |     Some(ErrorSpan::new(self.range.start, self.range.end))
47 | |   }
   | |___^ not a member of trait `Dependency`
@shulaoda shulaoda added bug Something isn't working pending triage The issue/PR is currently untouched. labels Sep 10, 2024
@shulaoda
Copy link
Collaborator Author

You can create a new branch based on the commit history prior to commit f19562 to reproduce the issue.

image

@SoonIter
Copy link
Member

I used to be troubled by this problem too... 😂
Can I see the specific wrong github action link?

@shulaoda
Copy link
Collaborator Author

I used to be troubled by this problem too... 😂 Can I see the specific wrong github action link?

At present, only Action records are available, and the PR has been updated.

https://github.com/web-infra-dev/rspack/actions/runs/10786518541/job/29913523550

@SoonIter
Copy link
Member

It is relatively difficult to locate the problem, which may be due to the following reasons

  1. checkout action bug (I checked the commit hash, it is fine)
  2. ci status is dirty (only in self-hosted machine)
  3. cargo cache

Wait for the next time repro.

@LingyuCoder LingyuCoder removed the pending triage The issue/PR is currently untouched. label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants