[Feature]: Standardize the type of the request property in the dependencies

[shulaoda]

Description

I noticed that in some Dependencies, the types of requests are not consistent, some use String while others use Atom. What is the best choice? @h-a-n-a cc

rspack/crates/rspack_plugin_javascript/src/dependency/esm/import_eager_dependency.rs

Lines 13 to 21 in b702681

	#[derive(Debug, Clone)]
	pub struct ImportEagerDependency {
	id: DependencyId,
	request: Atom,
	range: RealDependencyLocation,
	referenced_exports: Option<Vec<Atom>>,
	attributes: Option<ImportAttributes>,
	resource_identifier: String,
	}

rspack/crates/rspack_core/src/dependency/entry.rs

Lines 7 to 14 in b702681

	#[derive(Debug, Hash, PartialEq, Eq, Clone)]
	pub struct EntryDependency {
	id: DependencyId,
	request: String,
	context: Context,
	layer: Option<ModuleLayer>,
	is_global: bool,
	}

[h-a-n-a]

Thanks for raising this! This is probably related to the whole repo. I cannot make a quick conclusion at the moment. Let's make sure we are on the same page and provide as much information as possible before discussing this.

Some resources:

• Proper string type for rolldown rolldown/rolldown#427
• https://kdy1.dev/2023-10-14-a-journey-towards-a-proper-string-type
• https://fasterthanli.me/articles/small-strings-in-rust
• https://github.com/rosetta-rs/string-rosetta-rs

Things I believe:

• Should keep dependency(string type) as small as possible as we don't want that much of heap allocations
• String type(for dependencies and modules) should be lock-free globally as dependencies and modules are created parallely
• We do not necessarily need to use only one string type. Different types should be suitable for different cases

Will get back to you soon as soon as I have some idea.

[shulaoda]

Will get back to you soon as soon as I have some idea.

Thanks for your clarification！

[hardfist]

I think we should at least use Request new type to unify request usage first

struct Request(Atom);

then we can investigate what's best implementation detail of how to store request