Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add domain parameter to serve Verba #226

Open
1 of 2 tasks
priamai opened this issue Jun 23, 2024 · 2 comments
Open
1 of 2 tasks

add domain parameter to serve Verba #226

priamai opened this issue Jun 23, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@priamai
Copy link

priamai commented Jun 23, 2024

Description

A typical user will want to host Verba behind a web proxy or a load balancer which will be fronted by a domain.

Is this a bug or a feature?

  • Bug
  • Feature

Steps to Reproduce

Launch your Verba locally:

verba start --host localhost --port 8080

Then for example add an ngrok SSL proxy:
ngrok http --domain=mycooldomain.com 8080

This will result in a forever Loading Verba screen, because the api.ts file is hardcoded with localhost.

Suggestion

I suggest to add another parameter into Verba which will then override the localhost in api.ts

For example:

verba start --host localhost --domain mycooldomain.com --port 8080

@priamai
Copy link
Author

priamai commented Jun 24, 2024

Also for reference I did also attempt to rewrite the host header:

verba start --host localhost --port 8080
ngrok http --domain=mycooldomain.com 8080 --host-header="localhost:8080"

and is still having the same issue.

@thomashacker thomashacker added the enhancement New feature or request label Jun 27, 2024
@thomashacker
Copy link
Collaborator

Interesting use case! Thanks for the issue, we're looking into it 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants