Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

probe: avoid reporting the container ID as its hostname #3746

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bboreham
Copy link
Collaborator

If hostname isn't set on a container it defaults to a random hex number, which we don't want to show in the UI.

If hostname isn't set on a container it defaults to a random hex
number which we don't want to show in the UI.
Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable change :)

I didn't come across this before - do you have an example at hand that you paste / link to here?

@bboreham
Copy link
Collaborator Author

Example: you can see that the hostname of the container is the first 12 characters of the container ID.

image

@bboreham
Copy link
Collaborator Author

However, with this PR the second container disappears from the "containers by DNS name" view.
I'm not sure that is an improvement.

@bboreham bboreham marked this pull request as draft April 9, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants