Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow storing sync secrets per project #80

Closed
swissspidy opened this issue Oct 30, 2018 · 0 comments
Closed

Allow storing sync secrets per project #80

swissspidy opened this issue Oct 30, 2018 · 0 comments
Labels
[Component] API Concerns REST API Endpoints, e.g. for incoming webhooks [Type] Enhancement New functionality
Milestone
3.0.0

Comments

@swissspidy
Copy link
Collaborator

Defining these secrets in wp-config.php means you can't easily use this with Multisite or with multiple self-managed GitLab repositories unless they all share the same secret.

Retrieving the secret could be filterable and we could still fall back to the defined constants there for BC.

Related #57.
@swissspidy swissspidy added the [Type] Enhancement New functionality label Oct 30, 2018
@swissspidy swissspidy mentioned this issue Oct 30, 2018
Open
@swissspidy swissspidy added the [Component] API Concerns REST API Endpoints, e.g. for incoming webhooks label Nov 2, 2018
@swissspidy swissspidy mentioned this issue Nov 2, 2018
Merged
3 tasks
@swissspidy swissspidy added this to the 3.0.0 milestone Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Component] API Concerns REST API Endpoints, e.g. for incoming webhooks [Type] Enhancement New functionality
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@swissspidy