Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more unique temp folder for Traduttore #72

Open
swissspidy opened this issue Oct 26, 2018 · 2 comments
Open

Use more unique temp folder for Traduttore #72

swissspidy opened this issue Oct 26, 2018 · 2 comments
Labels
[Priority] Low Not urgent [Type] Enhancement New functionality [Type] Question Support requests and other types of questions

Comments

@swissspidy
Copy link
Collaborator

Just so there aren't any conflicts when there are multiple Traduttore installs on a server.

Code in question:

/**
* Returns the path to where the Git repository should be checked out.
*
* @since 3.0.0
*
* @return string Git repository path.
*/
public function get_local_path() : string {
return sprintf(
'%1$s-traduttore-%2$s-%3$s',
get_temp_dir(),
$this->repository->get_host(),
$this->repository->get_slug()
);
}

@swissspidy swissspidy added [Type] Enhancement New functionality [Type] Question Support requests and other types of questions labels Oct 26, 2018
@swissspidy
Copy link
Collaborator Author

Some providers like GitHub support both Git and SVN for the same repo. For this reason we should include the vcs type in the path

@swissspidy swissspidy added the [Priority] Low Not urgent label Nov 4, 2018
@swissspidy
Copy link
Collaborator Author

It would be nice if everything would be under /tmp/traduttore or something.

As for the VCS type, this could be a sub folder of the repository dir, e.g. /tmp/traduttore/github-wearerequired-traduttore/git or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] Low Not urgent [Type] Enhancement New functionality [Type] Question Support requests and other types of questions
Projects
None yet
Development

No branches or pull requests

1 participant