From 252737fdc73cebe650195d655d4fa7c43c444a01 Mon Sep 17 00:00:00 2001
From: Saleem Abdulrasool <compnerd@compnerd.org>
Date: Sun, 9 May 2021 15:20:29 -0700
Subject: [PATCH] git: avoid invoking the git process through a shell

Use the newly minted `execute` to directly execute the `git` process.
This should be a slight bit faster as no new shell process needs to be
setup.
---
 src/git.js | 28 ++++++++++++----------------
 1 file changed, 12 insertions(+), 16 deletions(-)

diff --git a/src/git.js b/src/git.js
index bfd84822..e52ef1f7 100644
--- a/src/git.js
+++ b/src/git.js
@@ -1,6 +1,6 @@
 const core = require("@actions/core");
 
-const { run } = require("./utils/action");
+const { execute } = require("./utils/action");
 
 /**
  * Fetches and checks out the remote Git branch (if it exists, the fork repository will be used)
@@ -10,27 +10,23 @@ function checkOutRemoteBranch(context) {
 	if (context.repository.hasFork) {
 		// Fork: Add fork repo as remote
 		core.info(`Adding "${context.repository.forkName}" fork as remote with Git`);
-		run(
-			`git remote add fork https://${context.actor}:${context.token}@github.com/${context.repository.forkName}.git`,
-		);
+		execute("git", ["remote", "add", "fork", `https://${context.actor}:${context.token}@github.com/${context.repository.forkName}.git`]);
 	} else {
 		// No fork: Update remote URL to include auth information (so auto-fixes can be pushed)
 		core.info(`Adding auth information to Git remote URL`);
-		run(
-			`git remote set-url origin https://${context.actor}:${context.token}@github.com/${context.repository.repoName}.git`,
-		);
+		execute("git", ["remote", "set-url", "origin", `https://${context.actor}:${context.token}@github.com/${context.repository.repoName}.git`]);
 	}
 
 	const remote = context.repository.hasFork ? "fork" : "origin";
 
 	// Fetch remote branch
 	core.info(`Fetching remote branch "${context.branch}"`);
-	run(`git fetch --no-tags --depth=1 ${remote} ${context.branch}`);
+	execute("git", ["fetch", "--no-tags", "--depth=1", remote, context.branch]);
 
 	// Switch to remote branch
 	core.info(`Switching to the "${context.branch}" branch`);
-	run(`git branch --force ${context.branch} --track ${remote}/${context.branch}`);
-	run(`git checkout ${context.branch}`);
+	execute("git", ["branch", "--force", context.branch, "--track", `${remote}/${context.branch}`]);
+	execute("git", ["checkout", context.branch]);
 }
 
 /**
@@ -39,7 +35,7 @@ function checkOutRemoteBranch(context) {
  */
 function commitChanges(message) {
 	core.info(`Committing changes`);
-	run(`git commit -am "${message}"`);
+	execute("git", ["commit", "-am", `"${message}"`]);
 }
 
 /**
@@ -47,7 +43,7 @@ function commitChanges(message) {
  * @returns {string} - Head SHA
  */
 function getHeadSha() {
-	const sha = run("git rev-parse HEAD").stdout;
+	const sha = execute("git", ["rev-parse", "HEAD"]).stdout;
 	core.info(`SHA of last commit is "${sha}"`);
 	return sha;
 }
@@ -57,7 +53,7 @@ function getHeadSha() {
  * @returns {boolean} - Boolean indicating whether changes exist
  */
 function hasChanges() {
-	const output = run("git diff-index --name-status --exit-code HEAD --", { ignoreErrors: true });
+	const output = execute("git", ["diff-index", "--name-status", "--exit-code", "HEAD", "--"], { ignoreErrors: true });
 	const hasChangedFiles = output.status === 1;
 	core.info(`${hasChangedFiles ? "Changes" : "No changes"} found with Git`);
 	return hasChangedFiles;
@@ -68,7 +64,7 @@ function hasChanges() {
  */
 function pushChanges() {
 	core.info("Pushing changes with Git");
-	run("git push");
+	execute("git", ["push"]);
 }
 
 /**
@@ -78,8 +74,8 @@ function pushChanges() {
  */
 function setUserInfo(name, email) {
 	core.info(`Setting Git user information`);
-	run(`git config --global user.name "${name}"`);
-	run(`git config --global user.email "${email}"`);
+	execute("git", ["config", "--global", "user.name", `"${name}"`]);
+	execute("git", ["config", "--global", "user.email", `"${email}"`]);
 }
 
 module.exports = {