Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO before V1.0 #24

Open
tsnobip opened this issue Jan 27, 2020 · 0 comments
Open

TODO before V1.0 #24

tsnobip opened this issue Jan 27, 2020 · 0 comments

Comments

@tsnobip
Copy link
Contributor

tsnobip commented Jan 27, 2020

Here is a list of things that should be fixed before releasing a v1.0 in my opinion (by decreasing level of importance):

  • clean existing .rei files by adding external and bs annotations in order to let the compiler's optimization and inlining kick in
  • add missing .rei files (see Add missing REIs #22)
  • fix visibility of modules so only public names could be accessed by consumers (PM.View instead and PM_View for example)
  • flag correctly unsafe functions (see Unsafe functions #10)
  • add this binding to Plugin props and StateField functions.
  • remove static functions and constructors from functors mimicking class inheritance (since those bindings depend on a litteral (hence static) string in bs.scope)
  • fix or remove complex and incorrect bindings like EditorView.someProp, Step.jsonID or Selection.jsonID
  • find a way to display docs for functions created by functors (that would probably need some work on the Reason Language Server so a bit off-topic, otherwise we would have to copy the doc for every function of the functor in the .rei file).
  • remove orderedmap.bs.js from git

We're very close to 0 runtime cost for our bindings, I think the only thing that doesn't follow this rule is how we model this binding, hopefully that could change soon with the new way to model uncurried functions teased by Hongbo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant