Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App should check for running instances when app binary is directly used as CLI interface with wrong arguments and give a notification about multiple running instances #3424

Open
waydabber opened this issue Sep 19, 2024 · 2 comments
Assignees
Labels
done All tasks are completed enhancement New feature or request unreleased Not released yet in beta form
Milestone

Comments

@waydabber
Copy link
Owner

waydabber commented Sep 19, 2024

When there are uninterpreted arguments provided to the app binary, the app will respond with Some uninterpreted or system arguments are present - proceeding with app launch. - however this behavior might not be the desired one when the app is already running.

This results in this:
Screenshot_2024-09-19_at_1 19 24_AM

@waydabber waydabber added enhancement New feature or request in progress Implementing unreleased Not released yet in beta form labels Sep 19, 2024
@waydabber waydabber added this to the v3.0.6 milestone Sep 19, 2024
@waydabber waydabber self-assigned this Sep 19, 2024
@waydabber
Copy link
Owner Author

waydabber commented Sep 19, 2024

The app will now respond with this message and refrain from launching an additional instance when an app instance is detected to be running already. This probably aligns better with the intention of the user.

Some uninterpreted or system arguments are present - would proceed with app launch, but an instance is already running so exiting instead. To launch an additional instance deliberately, please launch the app binary with no arguments or add the 'skipArgumentsCheck' argument to skip this check.

@waydabber waydabber added done All tasks are completed and removed in progress Implementing labels Sep 19, 2024
@waydabber
Copy link
Owner Author

waydabber commented Sep 19, 2024

Decided not to fix this instead as the solution would not work well in a multi-user environment (there are legitimate reasons to have multiple instances running) and identifying the user ID of processes is not straightforward enough to reliably build a solution based on that (or it would be overkill to fix this issue).

The app will still show a warning about multiple instances but not prevent launching these, for example:

Some uninterpreted or system arguments are present - proceeding with app launch. Please note that the app already had 2 running instances and now an additional instance was started. This might not be what was intended!

@waydabber waydabber changed the title App should not launch a new instance when app binary is directly used as CLI interface with wrong arguments App should check for running instances when app binary is directly used as CLI interface with wrong arguments Sep 19, 2024
@waydabber waydabber changed the title App should check for running instances when app binary is directly used as CLI interface with wrong arguments App should check for running instances when app binary is directly used as CLI interface with wrong arguments and give a notification about multiple running instances Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done All tasks are completed enhancement New feature or request unreleased Not released yet in beta form
Projects
None yet
Development

No branches or pull requests

1 participant