Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive Zero Order Flowsheets #1445

Open
2 tasks
MarcusHolly opened this issue Jun 20, 2024 · 1 comment
Open
2 tasks

Archive Zero Order Flowsheets #1445

MarcusHolly opened this issue Jun 20, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request Priority:Normal Normal Priority Issue or PR zo-model

Comments

@MarcusHolly
Copy link
Contributor

MarcusHolly commented Jun 20, 2024

Description

All of the zero-order flowsheets were deleted in #1438, so a separate repository should be made that archives these now-deleted files.

Motivation

We still want these flowsheets to be accessible if necessary, but it's not worth the effort to constantly maintain them.

To do

  • Create repository e.g. watertap-org/zero-order-flowsheets (@lbianchi-lbl)
  • Figure out the most appropriate structure and a concrete list of what flowsheets should be there (@lbianchi-lbl, @MarcusHolly)
@MarcusHolly MarcusHolly added the enhancement New feature or request label Jun 20, 2024
@lbianchi-lbl lbianchi-lbl added Priority:Normal Normal Priority Issue or PR zo-model labels Jun 27, 2024
@adam-a-a
Copy link
Contributor

EDIT: We decided to only remove the ZO flowsheets for now and not the units with associated docs/data. Thus the repo will be just for the flowsheets and possibly the associated yaml files for setting parameters in flowsheets.

@adam-a-a adam-a-a changed the title Archive Zero Order Models Archive Zero Order Flowsheets Jun 28, 2024
@ksbeattie ksbeattie added Priority:High High Priority Issue or PR and removed Priority:Normal Normal Priority Issue or PR labels Jul 11, 2024
@ksbeattie ksbeattie added Priority:Normal Normal Priority Issue or PR and removed Priority:High High Priority Issue or PR labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority:Normal Normal Priority Issue or PR zo-model
Projects
None yet
Development

No branches or pull requests

4 participants