Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Eleventy files into src/ #37

Merged
merged 1 commit into from
Aug 6, 2023
Merged

Move Eleventy files into src/ #37

merged 1 commit into from
Aug 6, 2023

Conversation

higby
Copy link
Contributor

@higby higby commented Aug 3, 2023

Changes

  • eleventy.config.js specifies the input directory as src/1
  • Append src/ to passthrough copies because they are "relative to the root of your project and not your Eleventy input directory"2
  • The .eleventyignore files is no longer necessary as Eleventy no longer sees README.md
  • All of Eleventy's files (except for eleventy.config.js) are moved into src/

Justification

The purpose of this pull request is to clean up the codebase a tad. It takes the Eleventy files out of the project root, making it clearer to navigate and recognize what is and isn't going to affect the output.

Testing the build script shows that nothing about the output is affected by these changes.

Ultimately it is a DX change and not entirely necessary, but I thought I might as well suggest.

Footnotes

  1. Configuration — Eleventy

  2. Passthrough File Copy — Eleventy

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for wallabag-website ready!

Name Link
🔨 Latest commit 35c3220
🔍 Latest deploy log https://app.netlify.com/sites/wallabag-website/deploys/64cbc42ad6971b0008e034b0
😎 Deploy Preview https://deploy-preview-37--wallabag-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nicosomb nicosomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Thank you so much @higby.

I prefer to have @jbleuzen's review before merging 😊

@jbleuzen
Copy link
Collaborator

jbleuzen commented Aug 6, 2023

I'm not sure to like the fact to have the content of the website inside a source folder.
But if it's the recommended way to do, let's go for it…

@nicosomb nicosomb merged commit 9c20088 into wallabag:main Aug 6, 2023
5 checks passed
@higby higby mentioned this pull request Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants