tests: move docker service start in pytest #351
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves logic in charge of starting docker service
wallabag
in pytest, using pytest-docker. This let us avoid putting sleep steps in the CI.As pytest-docker does not provide a way to print service logs, we still rely on additional calls to
docker-compose logs
anddocker-compose down -v
after tests are finished, see avast/pytest-docker#13