Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-foss greendao plugin #1406

Merged
merged 2 commits into from
May 24, 2024
Merged

Remove non-foss greendao plugin #1406

merged 2 commits into from
May 24, 2024

Conversation

di72nn
Copy link
Member

@di72nn di72nn commented May 22, 2024

Add generated DAO classes, remove the generator plugin. I just added the generated classes as is.

A temporary measure to allow app updates be published on F-Droid. The proper solution would be to get rid of greendao, but I can't look into it at the moment.

Kinda resolves #1399.

Upd: clarification: without the generator the DAO classes are not automatically updated when the model classes change (but the model hasn't changed in a while).

Add generated DAO classes, remove the generator plugin.
@tcitworld tcitworld merged commit 2a1b2de into master May 24, 2024
2 checks passed
@tcitworld tcitworld deleted the remove_greendao_plugin branch May 24, 2024 06:35
@blundell
Copy link

@di72nn I'm looking to do the same on another project. Could you briefly explain where the generated classes are located? and any other info about this migration that could help pls :-)

@di72nn
Copy link
Member Author

di72nn commented May 27, 2024

Sure, @blundell. This is not a proper solution, mind you.

First, you have to build the project locally at least once, so the generator plugin actually generates the source files.

Then the generated sources should be in app/build/generated/source/greendao/<your package>, where <your package> is the DAO package (defined by daoPackage in one of the build.gradle files).

In a non-complicated scenario this is just a matter of moving files to the main source tree (you should be able to drag-n-drop, maybe creating the target package in advance):
Screenshot_20240527_220131

After that the greendao plugin can be removed from build.gradle files (see the PR changes).

@blundell
Copy link

Awesome, appreciate that - going to attempt it this week. TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F-Droid issue: The greendao gradle plugin is not FOSS
4 participants