Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deliverable] Review connection management strategy & back-off & long disconnection issues #177

Closed
1 task done
chair28980 opened this issue Jun 3, 2024 · 6 comments
Closed
1 task done
Assignees
Labels
Deliverable Tracks a Deliverable

Comments

@chair28980
Copy link
Contributor

chair28980 commented Jun 3, 2024

Epics

Output

Several fixes. Effect can be seen when using Status apps 2.30.0. For example:

Detects disconnection due to hibernation (white 2.29.0, black 2.30.0):

relay_-_recover_from_suspend.1.mp4
@chair28980 chair28980 added the Deliverable Tracks a Deliverable label Jun 3, 2024
@fryorcraken fryorcraken added this to Waku Jun 3, 2024
@chair28980 chair28980 changed the title Deliverable: Review connection management strategy & back-off & long disconnection issues [Deliverable] Review connection management strategy & back-off & long disconnection issues Jun 3, 2024
@chair28980 chair28980 added this to the Direct Message Reliability milestone Jun 6, 2024
@fryorcraken
Copy link
Contributor

This deliverable seems to be well progressed.
I suggest an increase of scope to include the peer discovery work in it.
Scoping may need review as Waku Research is now involved..

What is the current status and do we have some ETA?
@plopezlpz @chaitanyaprem @jm-clius

@jm-clius
Copy link

I've been considering the peer discovery improvements as part of waku-org/go-waku#1231
Work is progressing: first step is to add measurements to understand how well discovery is currently behaving. This is almost done. The next step is to try various ways of tuning discv5 to see if we can improve the situation for Status specifically. After that we'll consider adding more discovery methods, e.g. rendezvous. ETA would be roughly three months.

@fryorcraken
Copy link
Contributor

I've been considering the peer discovery improvements as part of waku-org/go-waku#1231 Work is progressing: first step is to add measurements to understand how well discovery is currently behaving. This is almost done. The next step is to try various ways of tuning discv5 to see if we can improve the situation for Status specifically. After that we'll consider adding more discovery methods, e.g. rendezvous. ETA would be roughly three months.

Fair enough. There was a feeling of urgency at first on discv5 but I believe it is now mitigated by also using peer exchange.

If peer discovery is in a fair state at this point in time (cc @chaitanyaprem ) then happy for it to be done as part of waku-org/go-waku#1231.

@chaitanyaprem
Copy link

I've been considering the peer discovery improvements as part of waku-org/go-waku#1231 Work is progressing: first step is to add measurements to understand how well discovery is currently behaving. This is almost done. The next step is to try various ways of tuning discv5 to see if we can improve the situation for Status specifically. After that we'll consider adding more discovery methods, e.g. rendezvous. ETA would be roughly three months.

Fair enough. There was a feeling of urgency at first on discv5 but I believe it is now mitigated by also using peer exchange.

If peer discovery is in a fair state at this point in time (cc @chaitanyaprem ) then happy for it to be done as part of waku-org/go-waku#1231.

Yes, we can consider this to be done for now. Any new issues observed can be tracked separately.

Whatever additional peer discovery related work is being done, better to take it separately as @jm-clius mentioned.

@chaitanyaprem
Copy link

@chair28980 we can mark this as completed.

@chair28980
Copy link
Contributor Author

cc @fryorcraken for completion check

@chair28980 chair28980 moved this to In Progress in Waku Aug 19, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Waku Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deliverable Tracks a Deliverable
Projects
Status: Done
Development

No branches or pull requests

4 participants