Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: metadata protocol is not being configured with shards resolved from --content-topic CLI flag #3062

Open
gabrielmer opened this issue Sep 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working effort/hours Estimated to be completed in a few hours

Comments

@gabrielmer
Copy link
Contributor

Problem

The --content-topic CLI flag helps us resolve and subscribe to shards that correspond to content topics that we will use via autosharding.

It seems that the resolved shards are not being included in the node's ENR and the metadata protocol is also not considering those shards as subscribed.

We can see it from the following logs

xxxxxxx@srv:~$ docker run -i -t -p 60002:60002 -p 9002:9002/udp -p 8002:8002 wakuorg/nwaku:latest   --nodekey=5fbdf3bd7c9f54fb64cabe51349f00ecff0893326176284a1fc5e92ec80e2a5c   --tcp-port=60002   --dns-discovery=true   --discv5-discovery=true   --discv5-udp-port=9002   --discv5-enr-auto-update   --nat=extip:case   --websocket-support=true   --websocket-port=8002   --content-topic=/AtomSwaps/2/default/rfc26   --lightpush=true   --filter=true   --store=true   --relay-peer-exchange=true --cluster-id=202
NTC 2024-09-26 21:41:54.889+00:00 REST service started                       tid=1 file=server.nim:186 address=127.0.0.1:8645
INF 2024-09-26 21:41:54.889+00:00 Starting REST HTTP server                  tid=1 file=builder.nim:105 url=http://127.0.0.1:8645/
INF 2024-09-26 21:41:54.893+00:00 Running nwaku node                         topics="wakunode main" tid=1 file=waku.nim:160 version=v0.32.0-25-g51391a
INF 2024-09-26 21:41:54.893+00:00 Configuration: Enabled protocols           topics="wakunode waku" tid=1 file=waku.nim:61 relay=true rlnRelay=false store=true filter=true lightpush=true peerExchange=false
INF 2024-09-26 21:41:54.893+00:00 Configuration. Network                     topics="wakunode waku" tid=1 file=waku.nim:69 cluster=202 maxPeers=none(int)
INF 2024-09-26 21:41:54.893+00:00 Configuration. Shards                      topics="wakunode waku" tid=1 file=waku.nim:72 shard=0
INF 2024-09-26 21:41:54.893+00:00 Configuration. Shards                      topics="wakunode waku" tid=1 file=waku.nim:72 shard=1
INF 2024-09-26 21:41:54.893+00:00 Configuration. Shards                      topics="wakunode waku" tid=1 file=waku.nim:72 shard=2
INF 2024-09-26 21:41:54.893+00:00 Configuration. Shards                      topics="wakunode waku" tid=1 file=waku.nim:72 shard=3
INF 2024-09-26 21:41:54.893+00:00 Configuration. Shards                      topics="wakunode waku" tid=1 file=waku.nim:72 shard=4
INF 2024-09-26 21:41:54.893+00:00 Configuration. Shards                      topics="wakunode waku" tid=1 file=waku.nim:72 shard=5
INF 2024-09-26 21:41:54.893+00:00 Configuration. Shards                      topics="wakunode waku" tid=1 file=waku.nim:72 shard=6
INF 2024-09-26 21:41:54.893+00:00 Configuration. Shards                      topics="wakunode waku" tid=1 file=waku.nim:72 shard=7
INF 2024-09-26 21:41:54.893+00:00 Initializing networking                    tid=1 file=waku_node.nim:156 addrs="@[/ip4/xx.xx.xx.xx/tcp/60002, /ip4/xx.xx.xx.xx/tcp/8002/ws]"
INF 2024-09-26 21:41:54.893+00:00 Created WakuMetadata protocol              topics="waku node" tid=1 file=protocol.nim:118 clusterId=202 shards="{3, 4, 2, 6, 5, 7, 0, 1}"
WRN 2024-09-26 21:41:54.893+00:00 Number of shards in network not configured, setting it to tid=1 file=node_factory.nim:141 numShardsInNetwork=1024
INF 2024-09-26 21:41:54.893+00:00 mounting sharding                          topics="waku node" tid=1 file=waku_node.nim:257 clusterId=202 shardCount=1024
INF 2024-09-26 21:41:54.893+00:00 mounting relay protocol                    topics="waku node" tid=1 file=waku_node.nim:449
INF 2024-09-26 21:41:54.893+00:00 relay mounted successfully                 topics="waku node" tid=1 file=waku_node.nim:469 shards="@[/waku/2/rs/202/0, /waku/2/rs/202/1, /waku/2/rs/202/2, /waku/2/rs/202/3, /waku/2/rs/202/4, /waku/2/rs/202/5, /waku/2/rs/202/6, /waku/2/rs/202/7, /waku/2/rs/202/827]"

In which shard 827 is resolved from the content topic but is not included when creating the Metadata protocol.

Expected behavior

The shards derived from the content topics should be included in the Metadata protocol and in the node's ENR

nwaku version/commit hash

b358c90

@gabrielmer gabrielmer added the bug Something isn't working label Sep 27, 2024
@gabrielmer gabrielmer self-assigned this Sep 27, 2024
@gabrielmer gabrielmer added the effort/hours Estimated to be completed in a few hours label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort/hours Estimated to be completed in a few hours
Projects
Status: Priority
Development

No branches or pull requests

1 participant