Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out Faker for @faker-js/faker #206

Closed
kevin-mitchell opened this issue Feb 3, 2022 · 1 comment
Closed

Swap out Faker for @faker-js/faker #206

kevin-mitchell opened this issue Feb 3, 2022 · 1 comment
Labels

Comments

@kevin-mitchell
Copy link

kevin-mitchell commented Feb 3, 2022

After the "switcheroo" that was pulled with Faker, I imagine that it would be a good idea to switch Faker out for the accepted "official" fork of the original project.

See: https://fakerjs.dev/

My understanding is that the best way to approach this swap would be to wait for the 6.0.0 release of @faker-js/faker (as of this ticket being created the current package is 6.0.0-alpha.5), then "just" swap out the libraries.

In a very quick test I found that it seems pretty simple to swap out "old faker" for "new faker", although I followed these steps https://github.com/faker-js/faker#typescript-support to make TypeScript happy (this may be unnecessary).

@jorgebodega
Copy link
Collaborator

Hi! I can make this change, but pls take a look on #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants