Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump package versions #161

Closed
11 of 13 tasks
jorgebodega opened this issue Oct 12, 2021 · 8 comments
Closed
11 of 13 tasks

Bump package versions #161

jorgebodega opened this issue Oct 12, 2021 · 8 comments
Assignees
Labels
dependencies Pull requests that update a dependency file next This will be probably fixed on next Release

Comments

@jorgebodega
Copy link
Collaborator

jorgebodega commented Oct 12, 2021

Currently some packages are outdated. We could update manually or try to update with some kind of bot, like renovate or dependabot.

This is the list

imagen

@jorgebodega jorgebodega added dependencies Pull requests that update a dependency file next This will be probably fixed on next Release labels Oct 12, 2021
@jorgebodega jorgebodega self-assigned this Oct 12, 2021
@jorgebodega
Copy link
Collaborator Author

I'm pretty sure we should discuss about what node version we support. This is pretty important, since Node 16 is going to be LTS this month, and because target are pretty diferent.

Node 12 tsconfig recommended
Node 14 tsconfig recommended
Node 16 tsconfig recommended

@hirsch88

@jorgebodega jorgebodega pinned this issue Oct 13, 2021
This was referenced Oct 14, 2021
@Dmitriyx
Copy link

we also need to upgrade faker dependency

yarn check v1.22.10 error "typeorm-seeding#faker" is wrong version: expected "4.1.0", got "5.5.3" error "nps#spawn-command-with-kill#ps-tree#event-stream" is wrong version: expected "=3.3.4", got "4.0.1" error Found 2 errors.

@jorgebodega
Copy link
Collaborator Author

faker is already upgraded on v1.6.2 but is not deployed because we do not have permission to do it. Check #156

@micalevisk
Copy link

will [email protected] be published soon? I want to use faker v5

$ npm info typeorm-seeding version
1.6.1

@jorgebodega
Copy link
Collaborator Author

New version cannot be released because of #153.

There is a workaround installing faker as a dependency and using it like

import * as faker from 'faker' // Use this instead of the other one
import { define } from 'typeorm-seeding'
import { User } from '../entities'

define(User, () => { ... })

@micalevisk
Copy link

oh of course. I felt dumb. Thanks

@jorgebodega
Copy link
Collaborator Author

I know that is not the ideal workaround.

If NPM token is not created when the next version will be ready, I will deploy it myself.

@jorgebodega jorgebodega unpinned this issue Dec 13, 2021
@jorgebodega
Copy link
Collaborator Author

Closing this, no versions could be deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file next This will be probably fixed on next Release
Projects
None yet
Development

No branches or pull requests

3 participants